Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 4: (2 comments) Thank you both! http://gerrit.cloudera.org:8080/#/c/16419/2/be/src/exec/kudu-util-ir.cc File be/src/exec/kudu-util-ir.cc: http://gerrit.cloudera.org:8080/#/c/16419/2/be/src/exec/kudu-util-ir.cc@32 PS2, Line 32: DCHECK(success); > That's incorrect, they are removed in release builds (i.e. when NDEBUG is s Okay. Good to know! http://gerrit.cloudera.org:8080/#/c/16419/2/be/src/exprs/kudu-partition-expr-ir.cc File be/src/exprs/kudu-partition-expr-ir.cc: http://gerrit.cloudera.org:8080/#/c/16419/2/be/src/exprs/kudu-partition-expr-ir.cc@40 PS2, Line 40: kudu::client::KuduPartitioner* kudu_partitioner = ctx->partitioner.get(); : DCHECK(kudu_partitioner != nullp > Now I see the point, I thought for some reason you were talking about '*row Done -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 14 Sep 2020 17:52:50 +0000 Gerrit-HasComments: Yes
