Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 2: I realized that this was the last use of GetCodegendComputeFnWrapper(), so it could be removed completely. It has several TODOs, which could be also removed, e.g.: https://github.com/apache/impala/blob/6c8a3dfc339e43a8992af2ff3429ba5940a061ec/be/src/exprs/scalar-expr.h#L141 Do you want to do this here, or it should be a separate patch for IMPALA-7656? -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2020 10:00:18 +0000 Gerrit-HasComments: No
