Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16419 )

Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr
......................................................................


Patch Set 7: -Code-Review

I have created a review to test what leads to the failures, and it seems that 
the changes in be/CMakeLists.txt

What I see as a sure way to avoid the issue is to wrap the call to Kudu behind 
one more non-Clang compiled function/class, and remove the new Kudu headers 
from ir compilation. It would nicer of course to do more investigation and find 
out what exactly is the problem.


--
To view, visit http://gerrit.cloudera.org:8080/16419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df
Gerrit-Change-Number: 16419
Gerrit-PatchSet: 7
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 23 Sep 2020 17:36:00 +0000
Gerrit-HasComments: No

Reply via email to