Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16419 )

Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr
......................................................................


Patch Set 7:

I also can't reproduce it locally, but I poked around a little bit. I ran with 
ninja -v and modified the command that compiles impala-ir.cc to output the 
preprocessed output. Looks like it's picking up the boost headers from 
/usr/include not the toolchain. Unclear why. Maybe that's the difference with 
the build server - it might not have boost installed at the system level, or 
something like that.

d /home/tarmstrong/Impala/impala/be/src/codegen && 
/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/llvm-5.0.1-p3/bin/clang++ 
-emit-llvm -c -std=c++14 -DIR_COMPILE -DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H 
-DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG -DBOOST_NO_EXCEPTIONS 
-DKUDU_HEADERS_NO_STUBS -fcolor-diagnostics -Wno-deprecated 
-Wno-return-type-c-linkage -fsigned-char -O1 -Werror -DADDRESS_SANITIZER 
--gcc-toolchain=/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/gcc-7.5.0 
-I/home/tarmstrong/Impala/impala/be/src 
-I/home/tarmstrong/Impala/impala/be/generated-sources 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/thrift-0.9.3-p8/include -I 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/glog-0.3.4-p3/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/gflags-2.2.0-p2/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/gtest-1.6.0/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/rapidjson-1.1.0/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/avro-1.7.4-p5/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/orc-1.6.2-p7/include -I 
-isystem/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/boost-1.61.0-p2/include
 
-isystem/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/kudu-5ad5d3d66/release/include
 -I/usr/lib/jvm/java-8-openjdk-amd64/include 
-I/usr/lib/jvm/java-8-openjdk-amd64/include/linux 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/re2-20190301/include 
-I/usr/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/bzip2-1.0.6-p2/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/zlib-1.2.8/include 
-I/usr/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/openldap-2.4.47/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/protobuf-3.5.1/include 
-I/opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/cctz-2.2/include 
impala-ir.cc -E -o impala-no-sse-tmp.preproc.cc -E


--
To view, visit http://gerrit.cloudera.org:8080/16419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df
Gerrit-Change-Number: 16419
Gerrit-PatchSet: 7
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 22 Sep 2020 19:03:05 +0000
Gerrit-HasComments: No

Reply via email to