Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16419 )
Change subject: IMPALA-10078: Proper codegen for KuduPartitionExpr ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/16419/7/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/16419/7/be/CMakeLists.txt@339 PS7, Line 339: "-isystem${BOOST_INCLUDEDIR}" > This seems to imply that boost includes are read from the system directorie -isystem mostly behaves the same as -I but has implications for search order and warnings - https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html Although I think the fact that we have -I/usr/include on the search path means that /usr/include has priority over the boost headers. I think that's creeping in from OPENSSL_INCLUDE_DIR. Maybe OPENSSL_INCLUDE_DIR and SASL_INCLUDE_DIR should be -isystem as well. -- To view, visit http://gerrit.cloudera.org:8080/16419 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcae34f71b407837e2c5f1b97aa230e490a268df Gerrit-Change-Number: 16419 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2020 18:37:13 +0000 Gerrit-HasComments: Yes
