Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15931 )
Change subject: IMPALA-9711: incrementally update aggregate profile ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/15931/9/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/15931/9/be/src/runtime/coordinator-backend-state.cc@789 PS9, Line 789: if (done_) { In the old Coordinator::BackendState::UpdateExecStats(), the completion timer is updated unconditionally. Here we only update it if done_ is true. Does that mean there are times that we used to be updating it that we now are not? For example, if finalize=true but some are not done? Does that matter? -- To view, visit http://gerrit.cloudera.org:8080/15931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e79a40a33d8e74464640ae5f95a1467a6713a Gerrit-Change-Number: 15931 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2020 20:36:13 +0000 Gerrit-HasComments: Yes
