Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15931 )
Change subject: IMPALA-9711: incrementally update aggregate profile ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/15931/10/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/15931/10/be/src/runtime/coordinator-backend-state.cc@539 PS10, Line 539: if (instance_stats.exec_stats_up_to_date_) continue; // Already applied. > I'm thinking through this check and wondering if it interacts with finalize You're right, I think we just need to better separate the logic for deciding when to update completion time vs the avg profile. I made some changes to do that, I think it's simpler in the end. -- To view, visit http://gerrit.cloudera.org:8080/15931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e79a40a33d8e74464640ae5f95a1467a6713a Gerrit-Change-Number: 15931 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 01 Oct 2020 19:36:04 +0000 Gerrit-HasComments: Yes
