Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15931 )
Change subject: IMPALA-9711: incrementally update aggregate profile ...................................................................... Patch Set 12: Code-Review+2 (1 comment) This makes sense to me. I had one small nit about a comment, but I'm going ahead and +2'ing it. http://gerrit.cloudera.org:8080/#/c/15931/11/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: http://gerrit.cloudera.org:8080/#/c/15931/11/be/src/runtime/coordinator-backend-state.h@289 PS11, Line 289: /// If UpdateExecStats() has been called since the last time 'profile_' was : /// updated with a status report. I.e. Update() was called without a corresponding : /// UpdateExecStats() call. Nit: This comment is a bit out of date with the new approach. -- To view, visit http://gerrit.cloudera.org:8080/15931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib03e79a40a33d8e74464640ae5f95a1467a6713a Gerrit-Change-Number: 15931 Gerrit-PatchSet: 12 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2020 18:03:00 +0000 Gerrit-HasComments: Yes
