Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16551 )
Change subject: IMPALA-10165: Implement Bucket and Truncate partition transforms for Iceberg tables ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java@24 PS2, Line 24: public class IcebergPartitionTransform extends StmtNode { Please add some comments. http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@247 PS2, Line 247: latest nit: current? http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@345 PS2, Line 345: int nit: in http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/16551/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4846 PS2, Line 4846: AnalysisError("CREATE TABLE tbl1 (i int, p1 int, p2 timestamp) " + : "PARTITION BY SPEC (p1 BUCKET, p2 DAY) STORED AS ICEBERG" + tblProperties, : "BUCKET and TRUNCATE partition transforms should have a parameter."); You could add this test for TRUNCATE as well. -- To view, visit http://gerrit.cloudera.org:8080/16551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc75cd23045b274885607c45886319f4f6da19de Gerrit-Change-Number: 16551 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 07 Oct 2020 12:58:40 +0000 Gerrit-HasComments: Yes
