Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 )
Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys ...................................................................... Patch Set 1: Code-Review+1 (1 comment) LGTM! Only giving it +1 to let Norbert take a look as well. http://gerrit.cloudera.org:8080/#/c/16590/1/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: http://gerrit.cloudera.org:8080/#/c/16590/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@253 PS1, Line 253: getSortingOrderExplainString Should we extend the explain string for the mixed case? E.g.: order by: LEXICAL: year, month, ZORDER: id, string_col But we can do it in a follow-up patch as well if we want this fix to be merged quickly. -- To view, visit http://gerrit.cloudera.org:8080/16590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30cbad711167b8b63c81837e497b36fd41be9b54 Gerrit-Change-Number: 16590 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 13 Oct 2020 11:50:55 +0000 Gerrit-HasComments: Yes
