Norbert Luksa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16590 )

Change subject: IMPALA-10233: zorder sort node should output rows in lexical 
order of partition keys
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16590/2/be/src/util/tuple-row-compare.cc
File be/src/util/tuple-row-compare.cc:

http://gerrit.cloudera.org:8080/#/c/16590/2/be/src/util/tuple-row-compare.cc@45
PS2, Line 45:     num_lexical_keys_(tsort_info.num_lexical_keys),
This should be tsort_info.num_lexical_keys_in_zorder (the build failed because 
of this).



--
To view, visit http://gerrit.cloudera.org:8080/16590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30cbad711167b8b63c81837e497b36fd41be9b54
Gerrit-Change-Number: 16590
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Norbert Luksa <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 14 Oct 2020 09:31:34 +0000
Gerrit-HasComments: Yes

Reply via email to