Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 )
Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Thanks for the quick fix! http://gerrit.cloudera.org:8080/#/c/16590/2/be/src/util/tuple-row-compare.cc File be/src/util/tuple-row-compare.cc: http://gerrit.cloudera.org:8080/#/c/16590/2/be/src/util/tuple-row-compare.cc@a356 PS2, Line 356: : : : : : : : BTW thanks for moving this to the constructor. Norbert: maybe we should measure the write overhead again. Also, I suspect that the overhead for dynamic partition inserts are now even less thanks to the mixed mode. -- To view, visit http://gerrit.cloudera.org:8080/16590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30cbad711167b8b63c81837e497b36fd41be9b54 Gerrit-Change-Number: 16590 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 Oct 2020 09:36:51 +0000 Gerrit-HasComments: Yes
