Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 )
Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Thanks for fixing this bug! http://gerrit.cloudera.org:8080/#/c/16590/5/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test: http://gerrit.cloudera.org:8080/#/c/16590/5/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test@87 PS5, Line 87: # IMPALA-10233: Z-order sort node should sort partition keys lexically. Maybe extend the explanation of this test case with "INSERT statement using both static and dynamic partitioning. We only need to lexically sort the dynamic partition columns. "? http://gerrit.cloudera.org:8080/#/c/16590/5/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test@117 PS5, Line 117: # IMPALA-10233: Z-order sort node should sort partition keys lexically. Maybe extend the explanation of this test case with "Test static partition INSERTs sorted by ZORDER. In this case we don't need sort expressions for the partition columns."? -- To view, visit http://gerrit.cloudera.org:8080/16590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30cbad711167b8b63c81837e497b36fd41be9b54 Gerrit-Change-Number: 16590 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Oct 2020 16:23:28 +0000 Gerrit-HasComments: Yes
