Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 )
Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys ...................................................................... Patch Set 5: > Patch Set 4: > > > Patch Set 4: Verified-1 > > > > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6574/ > > Missing changes on a test file. Now the order by string should be > > order by: LEXICAL: d ASC NULLS LAST, ZORDER: i > > instead of > > order by: ZORDER: d, i Sorry, it's actually a bug fe/src/main/java/org/apache/impala/planner/Planner.java. Just fixed it and added more tests. Could you help to have a look again? -- To view, visit http://gerrit.cloudera.org:8080/16590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30cbad711167b8b63c81837e497b36fd41be9b54 Gerrit-Change-Number: 16590 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Oct 2020 10:17:56 +0000 Gerrit-HasComments: No
