Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16590 )
Change subject: IMPALA-10233: zorder sort node should output rows in lexical order of partition keys ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Thank Zoltan! Carry on Zoltan's +2. http://gerrit.cloudera.org:8080/#/c/16590/5/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test: http://gerrit.cloudera.org:8080/#/c/16590/5/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test@87 PS5, Line 87: # IMPALA-10233: INSERT statement sorted by ZORDER using both static and > Maybe extend the explanation of this test case with "INSERT statement using Done http://gerrit.cloudera.org:8080/#/c/16590/5/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by-zorder.test@117 PS5, Line 117: ==== > Maybe extend the explanation of this test case with "Test static partition Done -- To view, visit http://gerrit.cloudera.org:8080/16590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30cbad711167b8b63c81837e497b36fd41be9b54 Gerrit-Change-Number: 16590 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 16 Oct 2020 00:49:30 +0000 Gerrit-HasComments: Yes
