Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 )
Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service ...................................................................... Patch Set 7: (2 comments) I was pleasantly surprised by how easy this was to understand. I think we're on the same page that we need to do some more things for production readiness, but I have few concerns about the current state of things for what it is. http://gerrit.cloudera.org:8080/#/c/16412/7/be/src/scheduling/remote-admission-control-client.cc File be/src/scheduling/remote-admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/16412/7/be/src/scheduling/remote-admission-control-client.cc@121 PS7, Line 121: // TODO: make this more sophisticated, eg. base it off benchmarks, make it Is there a JIRA for this? Might be an obstacle for production-readiness for shorter running queries. I think some kind of long-polling might work well with KRPC (we already do something like this for row batches - delaying the RPC response until the batch is queued). http://gerrit.cloudera.org:8080/#/c/16412/7/be/src/scheduling/remote-admission-control-client.cc@184 PS7, Line 184: // Failure of this rpc is not considered a query failure, so we just log it. Just thinking, but I think something like retrying the RPC then giving up and having some cleanup mechanism on the AC service would work. -- To view, visit http://gerrit.cloudera.org:8080/16412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594fc593a27b24b6952e381a9bc1a9a5c6b757ae Gerrit-Change-Number: 16412 Gerrit-PatchSet: 7 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 29 Oct 2020 00:11:06 +0000 Gerrit-HasComments: Yes
