Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 )
Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service ...................................................................... Patch Set 9: Code-Review+2 (4 comments) Looks good to merge modulo a few minor things http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-control-service.cc@159 PS9, Line 159: admission_state->admission_done = true; Can we file a JIRA to rework this so that this doesn't block the RPC thread (or if there's already one, link it here). At larger scale I think this could eat up all the RPC threads over time. http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-control-service.cc@236 PS9, Line 236: LOG(ERROR) << s; When would this error happen? Is this the appropriate log level? http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-controller.h@887 PS9, Line 887: QueueNode* queue_node, bool& coordinator_resource_limited); nit: should use pointer for output argument here and below. http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/remote-admission-control-client.cc File be/src/scheduling/remote-admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/remote-admission-control-client.cc@189 PS9, Line 189: const int num_retries = 3; Should we move these constants into a shared place? -- To view, visit http://gerrit.cloudera.org:8080/16412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594fc593a27b24b6952e381a9bc1a9a5c6b757ae Gerrit-Change-Number: 16412 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 24 Nov 2020 22:13:02 +0000 Gerrit-HasComments: Yes
