Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16412 )
Change subject: IMPALA-9930 (part 2): Introduce new admission control rpc service ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-control-service.cc@159 PS9, Line 159: admission_state->admission_done = true; > Can we file a JIRA to rework this so that this doesn't block the RPC thread IMPALA-10359 http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/admission-control-service.cc@236 PS9, Line 236: } > When would this error happen? Is this the appropriate log level? Currently, this shouldn't ever happen. I think logging as an ERROR instead of eg. at FATAL or DCHECK-ing or similar seems like the most defensive choice. http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/remote-admission-control-client.cc File be/src/scheduling/remote-admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/16412/9/be/src/scheduling/remote-admission-control-client.cc@189 PS9, Line 189: RPC_TIMEOUT_MS, RPC_BACKOFF_TIME_MS, "REMOTE_AC_RELEASE_BACKENDS"); > Should we move these constants into a shared place? Done -- To view, visit http://gerrit.cloudera.org:8080/16412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I594fc593a27b24b6952e381a9bc1a9a5c6b757ae Gerrit-Change-Number: 16412 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 30 Nov 2020 19:06:37 +0000 Gerrit-HasComments: Yes
