Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 )
Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py@140 PS2, Line 140: if not os.path.exists(diag_dir): optional: I think it would improve readability to extract some parts to separate functions, e.g. dump_debug_pages(self, diag_dir) and maybe trigger_impalad_minidumps() -- To view, visit http://gerrit.cloudera.org:8080/16690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16d26052d0664ee0b115e3611cd96047d8ada19d Gerrit-Change-Number: 16690 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 08:56:02 +0000 Gerrit-HasComments: Yes
