Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 )
Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py@139 PS2, Line 139: > It may help diagnose later on by putting the date and the timestamp (in a f Changed this to used datetime, so the directory would have a name like: metric_timeout_diags_20201103_13:51:32 http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py@140 PS2, Line 140: Impala processes (impalad, catalogd, statestored) have a signal handler for > optional: I think it would improve readability to extract some parts to sep I split out the logic for dumping JSON to a file and the logic for requesting a minidump. One hurdle is that I'm constructing the assert message as I go, so I'm leaving this as one big function for the time being. http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py@159 PS2, Line 159: "metric > May be useful to get a minidump for statestored? I was not be able to see c Statestore is usually less interesting, because it is mostly a publisher/subscriber daemon. There aren't per-query resources on statestored. I changed the code to also dump catalogd. Interestingly, pgrep has trouble finding it unless I look at the whole commandline (e.g. pgrep -f). Seems like a minor bug. -- To view, visit http://gerrit.cloudera.org:8080/16690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16d26052d0664ee0b115e3611cd96047d8ada19d Gerrit-Change-Number: 16690 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 22:06:08 +0000 Gerrit-HasComments: Yes
