Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16690 )
Change subject: IMPALA-9864: Produce a minidump when TestValidateMetrics fails ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Thanks a lot for addressing the comments! http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py@139 PS2, Line 139: > Changed this to used datetime, so the directory would have a name like: Done http://gerrit.cloudera.org:8080/#/c/16690/2/tests/common/impala_service.py@159 PS2, Line 159: "metric > Statestore is usually less interesting, because it is mostly a publisher/su Done -- To view, visit http://gerrit.cloudera.org:8080/16690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16d26052d0664ee0b115e3611cd96047d8ada19d Gerrit-Change-Number: 16690 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 22:28:23 +0000 Gerrit-HasComments: Yes
