Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16911/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16911/8//COMMIT_MSG@26 PS8, Line 26: set sleep(10) before launching the query retry : in a separate thread I think we need a debug action for this for adding test coverage. http://gerrit.cloudera.org:8080/#/c/16911/8/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/16911/8/tests/custom_cluster/test_query_retries.py@705 PS8, Line 705: def test_retrying_query_cancel(self): Do you verify that this new test fails without the fix? I ran it 40 times in my local branch without your fix. It always succeeds. I think it's rare to fail the query in RETRYING state. We may need to add a debug action to introduce some configurable sleeps in QueryDriver::RetryQueryFromThread(). -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 8 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Mon, 04 Jan 2021 12:24:00 +0000 Gerrit-HasComments: Yes
