Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/16911/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16911/8//COMMIT_MSG@26 PS8, Line 26: stom_cluster/test_query_retries.py and manually : tested 100 times to > I think we need a debug action for this for adding test coverage. Done http://gerrit.cloudera.org:8080/#/c/16911/8/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/16911/8/be/src/runtime/query-driver.cc@273 PS8, Line 273: dleRetryFailure(&status, &error_msg, request_st > Maybe I'm misunderstanding something. ClientRequestState::Finalize() just b This waits to finish the retry query's wait-thread. A normal process waits for the wait-thread to finish when QueryDriver::Finalize is called. But now the retry_request_state has not been moved to retried_client_request_state_. If not call retry_request_state->Finalize will hit the DCHECK in ClientRequestState::~ClientRequestState. You can use test_retrying_query_cancel to reproduce the leaking after fixed the HandleRetryFailure http://gerrit.cloudera.org:8080/#/c/16911/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16911/8/be/src/service/impala-server.cc@2248 PS8, Line 2248: user_has_profile_access = query_handle.user_has_profile_access(); > Any reason for not making was_retried = query_handle.WasRetried() && query_ Done http://gerrit.cloudera.org:8080/#/c/16911/8/tests/custom_cluster/test_query_retries.py File tests/custom_cluster/test_query_retries.py: http://gerrit.cloudera.org:8080/#/c/16911/8/tests/custom_cluster/test_query_retries.py@705 PS8, Line 705: statestored_args="--statestore_heartbeat_frequency_ms=60000") > Do you verify that this new test fails without the fix? I ran it 40 times i Done -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 06 Jan 2021 10:47:44 +0000 Gerrit-HasComments: Yes
