Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16911 )
Change subject: IMPALA-10413: fix impalad crashes when canceling the retrying query ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16911/10/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/16911/10/be/src/service/impala-server.cc@1369 PS10, Line 1369: LOG(ERROR) << Substitute("Query de-registration for query_id={0} failed: {1}", : PrintId(query_id, cause->GetDetail())); This is incorrect. Could you fix it by the way? It should be LOG(ERROR) << Substitute("Query de-registration for query_id=$0 failed: $1", PrintId(query_id), cause->GetDetail()); You can find this log in impalad.ERROR. -- To view, visit http://gerrit.cloudera.org:8080/16911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd7228acd0a70d33859029052239f9b9f795e5d Gerrit-Change-Number: 16911 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Mon, 11 Jan 2021 10:06:25 +0000 Gerrit-HasComments: Yes
