Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17080 )
Change subject: IMPALA-10515: Refactoring to support external frontend. ...................................................................... Patch Set 3: Code-Review+2 (2 comments) These changes look fine to me. http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@214 PS3, Line 214: static public Nit: Since we are using "public static" for other functions here (rather than "static public"), do the same here (and other locations in this file) for consistency. http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java@125 PS3, Line 125: use that otherwise Nit: Minor grammer thing: "use that. Otherwise," -- To view, visit http://gerrit.cloudera.org:8080/17080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70035ec082be09a9583275191248d085414b27dd Gerrit-Change-Number: 17080 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 19 Feb 2021 23:17:49 +0000 Gerrit-HasComments: Yes
