Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17080 )
Change subject: IMPALA-10515: Refactoring to support external frontend. ...................................................................... Patch Set 4: Code-Review+2 (3 comments) Thanks for the review. Carry +2 http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@214 PS3, Line 214: public static > Nit: Since we are using "public static" for other functions here (rather th Done http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/17080/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java@125 PS3, Line 125: use that. Otherwis > Nit: Minor grammer thing: "use that. Otherwise," Done http://gerrit.cloudera.org:8080/#/c/17080/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/17080/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@391 PS2, Line 391: root.getOutputSmap(), null, limit, analyticNodeSort, > line too long (92 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/17080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70035ec082be09a9583275191248d085414b27dd Gerrit-Change-Number: 17080 Gerrit-PatchSet: 4 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 20 Feb 2021 00:06:48 +0000 Gerrit-HasComments: Yes
