Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17080
to look at the new patch set (#4).
Change subject: IMPALA-10515: Refactoring to support external frontend.
......................................................................
IMPALA-10515: Refactoring to support external frontend.
This patch does some minimal refactoring of the frontend
code to allow an external frontend to leverage certain apis
and class variables. A couple of new methods are also added.
The changes include:
- modifying a few class methods to be public static
- changing visibility of a few private member variables to
protected for use by a derived class
- adding an alternate PlannerContext constructor
- passing an additional initialization parameter to BackendConfig
- minimal refactor of selectivity calculation for predicates
- refactor of count(*) optimization methods
- small changes to the validatePlan and useParallelPlan
- new clone method for functions and one for null literals
Testing:
- Ran PlannerTest and TpcdsPlannerTest
- Ran e2e TPCH tests for sanity check
- Since these are refactoring changes, no new tests are added in
this patch but once other supporting changes are done, I
anticipate adding sanity tests for external FE in a future commit.
Change-Id: I70035ec082be09a9583275191248d085414b27dd
---
M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java
M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java
M fe/src/main/java/org/apache/impala/analysis/CompoundPredicate.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/InPredicate.java
M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
M fe/src/main/java/org/apache/impala/analysis/TupleDescriptor.java
M fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/PlannerContext.java
M fe/src/main/java/org/apache/impala/planner/ScanNode.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/planner/SortNode.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
20 files changed, 126 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/17080/4
--
To view, visit http://gerrit.cloudera.org:8080/17080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70035ec082be09a9583275191248d085414b27dd
Gerrit-Change-Number: 17080
Gerrit-PatchSet: 4
Gerrit-Owner: Aman Sinha <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
