Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 )
Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@81 PS1, Line 81: public static synchronized Db getInstance(boolean initBuiltins) { Should we make 'initBuiltins' a static field so if someone call both getInstance(true) and getInstance(false) we can add Precondition checks to forbid it? http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@99 PS1, Line 99: private initBuiltins() is private. Will it be called after we init the singleton with initBuiltins=false? It seems so since the commit message mentions "allow the initialization to be deferred". If not, maybe we should rename 'initBuiltins' to something like 'withoutBuiltinFuncs' to be more specifit. -- To view, visit http://gerrit.cloudera.org:8080/17093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1941a2494efe15b63514d849873eeb1c4ed8a981 Gerrit-Change-Number: 17093 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 21 Feb 2021 09:02:48 +0000 Gerrit-HasComments: Yes
