Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 )
Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@91 PS1, Line 91: if (initBuiltins) { : initBuiltins(); : } This seems disable the init of all builtins. My concern is the following: 1. The 3rd party tools only provide some coverage in functionality, and relies on Impala's for the rest. If so, a reduced scope in bypassing the initBuiltins(this) calls would be better. 2. FE uses the builtIn functions to process a query, such as one containing NDV() function. So disabling these builtins entirely have an impact. An alternative approach would be to just disable the loading of the C++ signature part, which makes it more inline with the requirement to manage 3rd party tools that do not have the C++ implementations. -- To view, visit http://gerrit.cloudera.org:8080/17093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1941a2494efe15b63514d849873eeb1c4ed8a981 Gerrit-Change-Number: 17093 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 22 Feb 2021 14:00:39 +0000 Gerrit-HasComments: Yes
