Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 )
Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization ...................................................................... Patch Set 1: (1 comment) Sounds like a good idea to have a Loader and use it to verify that the content from the 3rd party tool is exactly the same as what is expected by Impala FE and all the way to BE. http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java File fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java: http://gerrit.cloudera.org:8080/#/c/17093/1/fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java@91 PS1, Line 91: if (initBuiltins) { : initBuiltins(); : } > See general comment for perhaps a better way to implement. Perhaps that a verifier should be coded to make sure that the 3rd party tools produce exact the same items as FE currently does. -- To view, visit http://gerrit.cloudera.org:8080/17093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1941a2494efe15b63514d849873eeb1c4ed8a981 Gerrit-Change-Number: 17093 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 22 Feb 2021 17:49:51 +0000 Gerrit-HasComments: Yes
