Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17110 )
Change subject: IMPALA-10450: Catalogd crashes due to exception in ThriftDebugString ...................................................................... Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/17110/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17110/6//COMMIT_MSG@13 PS6, Line 13: caught on the catalogd side and it crashes the catalogd. Will the thrift library has memory leak or corrupt memory after this? It'd be good if we can reproduce the exception in a stress test (manually) and see if catalogd still works normally after catching the exception. http://gerrit.cloudera.org:8080/#/c/17110/6/be/src/util/debug-util.h File be/src/util/debug-util.h: http://gerrit.cloudera.org:8080/#/c/17110/6/be/src/util/debug-util.h@196 PS6, Line 196: exception_str_map nit: EXCEPTION_STR_MAP http://gerrit.cloudera.org:8080/#/c/17110/6/be/src/util/thrift-debug-util.h File be/src/util/thrift-debug-util.h: http://gerrit.cloudera.org:8080/#/c/17110/6/be/src/util/thrift-debug-util.h@33 PS6, Line 33: nit: I think we can add 'noexcept' here -- To view, visit http://gerrit.cloudera.org:8080/17110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42cee6186a3d5bacc1117bae5961ac60ac9f7a66 Gerrit-Change-Number: 17110 Gerrit-PatchSet: 6 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 25 Feb 2021 02:28:52 +0000 Gerrit-HasComments: Yes
