Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17110 )
Change subject: IMPALA-10450: Catalogd crashes due to exception in ThriftDebugString ...................................................................... Patch Set 7: Code-Review+2 (1 comment) This makes sense to me. One small nit on a comment. Since Quanlong has already +1'd, I'm going to take this to +2. http://gerrit.cloudera.org:8080/#/c/17110/7/tests/custom_cluster/test_thrift_debug_string_exception.py File tests/custom_cluster/test_thrift_debug_string_exception.py: http://gerrit.cloudera.org:8080/#/c/17110/7/tests/custom_cluster/test_thrift_debug_string_exception.py@42 PS7, Line 42: The test executes a API call to get a catalog object from the debug UI and makes : sure that catalogd does not crash if the ThriftDebugString throws an exception. Nit: Could you note in this comment that this is a positive test where it should not throw an exception? -- To view, visit http://gerrit.cloudera.org:8080/17110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42cee6186a3d5bacc1117bae5961ac60ac9f7a66 Gerrit-Change-Number: 17110 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 02 Mar 2021 00:53:45 +0000 Gerrit-HasComments: Yes
