Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17110 )

Change subject: IMPALA-10450: Catalogd crashes due to exception in 
ThriftDebugString
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17110/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17110/6//COMMIT_MSG@13
PS6, Line 13: caught on the catalogd side and it crashes the catalogd.
Thanks for digging into this! The codes look safe for me.

> One thing which I tried is I updated the thrift library to throw a exception 
> and I looped around on the catalogd web API call for an hour. I observed the 
> memory usage of catalogd and it was stable.

That's cool! I'm ok if we can't reproduce the exception. I think this is enough.



--
To view, visit http://gerrit.cloudera.org:8080/17110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I42cee6186a3d5bacc1117bae5961ac60ac9f7a66
Gerrit-Change-Number: 17110
Gerrit-PatchSet: 7
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Mon, 01 Mar 2021 06:12:58 +0000
Gerrit-HasComments: Yes

Reply via email to