Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17199 )
Change subject: IMPALA-9661: Avoid introducing unused columns in table masking view ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17199/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/17199/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@541 PS3, Line 541: analysisResult_.stmt_ = > Yeah, when reAnalyze = false, we return at line 528. We call this at line 5 Ah, I missed the early return. For the second call, yeah comments would be good. http://gerrit.cloudera.org:8080/#/c/17199/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17199/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@860 PS3, Line 860: place "co > Yeah, it's actually a collection column. Here's an example query when the r Thanks for the explanation. Adding the comments makes sense. http://gerrit.cloudera.org:8080/#/c/17199/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/17199/3/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@268 PS3, Line 268: public boolean resolveTableMask(Analyzer analyzer) throws AnalysisException { > We only need to recurse in subqueries to replace all the catalog table/view It is not clear to me why WHERE clause is considered here but HAVING is not even though HAVING can have a subquery..for example: SELECT a, count(*) FROM t1 GROUP BY a HAVING count(*) > (SELECT min(b) FROM t2) If this is checked in another part of the code, that's fine.. maybe you can add the comments. -- To view, visit http://gerrit.cloudera.org:8080/17199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib015a8ab528065907b27fbdceb8e2818deb814e1 Gerrit-Change-Number: 17199 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 20 Mar 2021 01:18:14 +0000 Gerrit-HasComments: Yes
