Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17199 )
Change subject: IMPALA-9661: Avoid introducing unused columns in table masking view ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/17199/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17199/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@860 PS5, Line 860: making nit: masking http://gerrit.cloudera.org:8080/#/c/17199/5/testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test File testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test: http://gerrit.cloudera.org:8080/#/c/17199/5/testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test@88 PS5, Line 88: ---- QUERY Thanks for adding the HAVING clause test. I am not sure if it came up earlier in the review but since you are also examining the SELECT list expressions, there could be scalar subqueries there as well. It can occur at top level or within a CASE expr or an OVER clause. For example: SELECT int_col, (select min(bigint_col) from alltypestiny) as x from alltypes; SELECT int_col, case when id < (select min(id) from alltypestiny) then 0 else 1 end as x from alltypes t2; SELECT count(*) over (partition by case when id > (select min(id) from alltypestiny) then id else id + 5 end) as x from alltypes t2; All these are converted to a Nested loop join between alltypestiny and alltypes. Currently, Impala only supports non-correlated SELECT list subqueries. Could you add couple of such tests ? Sorry, I should have suggested these earlier. -- To view, visit http://gerrit.cloudera.org:8080/17199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib015a8ab528065907b27fbdceb8e2818deb814e1 Gerrit-Change-Number: 17199 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 21 Mar 2021 17:17:04 +0000 Gerrit-HasComments: Yes
