Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17199 )
Change subject: IMPALA-9661: Avoid introducing unused columns in table masking view ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/17199/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/17199/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@860 PS5, Line 860: maskin > nit: masking Done http://gerrit.cloudera.org:8080/#/c/17199/5/testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test File testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test: http://gerrit.cloudera.org:8080/#/c/17199/5/testdata/workloads/functional-query/queries/QueryTest/ranger_row_filtering.test@88 PS5, Line 88: ---- QUERY > Thanks for adding the HAVING clause test. I am not sure if it came up earli Sure. We do need coverage for this. Welcome for more test ideas! -- To view, visit http://gerrit.cloudera.org:8080/17199 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib015a8ab528065907b27fbdceb8e2818deb814e1 Gerrit-Change-Number: 17199 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 22 Mar 2021 02:10:11 +0000 Gerrit-HasComments: Yes
