Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17179 )
Change subject: IMPALA-10580: Implement ds_theta_union_f() function ...................................................................... Patch Set 3: (2 comments) Thanks for these changes! Do you plan to implement ds_theta_union() as an aggregate function as well? http://gerrit.cloudera.org:8080/#/c/17179/3/be/src/exprs/datasketches-functions-ir.cc File be/src/exprs/datasketches-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17179/3/be/src/exprs/datasketches-functions-ir.cc@167 PS3, Line 167: if (!first_serialized_sketch.is_null && first_serialized_sketch.len > 0) { : datasketches::theta_sketch::unique_ptr first_sketch_ptr; : if (!DeserializeDsSketch(first_serialized_sketch, &first_sketch_ptr)) { : LogSketchDeserializationError(ctx); : return StringVal::null(); : } : union_sketch.update(*first_sketch_ptr); : } This part seems pretty similar to L175-182. Have you considered introducing a function for this purpose? (e.g. update_sketch_toThera_union or such) http://gerrit.cloudera.org:8080/#/c/17179/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test: http://gerrit.cloudera.org:8080/#/c/17179/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test@436 PS3, Line 436: # Checks that ds_theta_union_f() returns an empty sketch for NULL inputs. Shouldn't this return null for null inputs? Have you checked the behaviour in Hive? -- To view, visit http://gerrit.cloudera.org:8080/17179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8329979b81ceeaad739a43fab79768ca9c2916fa Gerrit-Change-Number: 17179 Gerrit-PatchSet: 3 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 22 Mar 2021 10:26:49 +0000 Gerrit-HasComments: Yes
