Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/17179 )
Change subject: IMPALA-10580: Implement ds_theta_union_f() function ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17179/4/be/src/exprs/datasketches-functions-ir.cc File be/src/exprs/datasketches-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17179/4/be/src/exprs/datasketches-functions-ir.cc@163 PS4, Line 163: update_sketch_toThera_union Sorry it was my bad that I had a typo in my suggestion, but this function name is off a bit :) update_sketch_to_theta_union() would make much more sense. http://gerrit.cloudera.org:8080/#/c/17179/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test: http://gerrit.cloudera.org:8080/#/c/17179/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test@436 PS3, Line 436: # Checks that ds_theta_union_f() returns an empty sketch for NULL inputs. > ref: https://github.com/apache/datasketches-hive/blob/1.1.X-incubating/src/ thx -- To view, visit http://gerrit.cloudera.org:8080/17179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8329979b81ceeaad739a43fab79768ca9c2916fa Gerrit-Change-Number: 17179 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 24 Mar 2021 08:26:16 +0000 Gerrit-HasComments: Yes
