Fucun Chu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17179 )
Change subject: IMPALA-10580: Implement ds_theta_union_f() function ...................................................................... Patch Set 4: (2 comments) The ds_theta_union() function has been implemented in IMPALA-10467 http://gerrit.cloudera.org:8080/#/c/17179/3/be/src/exprs/datasketches-functions-ir.cc File be/src/exprs/datasketches-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17179/3/be/src/exprs/datasketches-functions-ir.cc@167 PS3, Line 167: if (!DeserializeDsSketch(serialized_sketch, &sketch_ptr)) { : LogSketchDeserializationError(ctx); : return false; : } : union_sketch.update(*sketch_ptr); : } : return true; : } > This part seems pretty similar to L175-182. Have you considered introducing Done http://gerrit.cloudera.org:8080/#/c/17179/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test: http://gerrit.cloudera.org:8080/#/c/17179/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test@436 PS3, Line 436: # Checks that ds_theta_union_f() returns an empty sketch for NULL inputs. > Shouldn't this return null for null inputs? Have you checked the behaviour ref: https://github.com/apache/datasketches-hive/blob/1.1.X-incubating/src/test/java/org/apache/datasketches/hive/theta/UnionSketchUDFTest.java#L36 -- To view, visit http://gerrit.cloudera.org:8080/17179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8329979b81ceeaad739a43fab79768ca9c2916fa Gerrit-Change-Number: 17179 Gerrit-PatchSet: 4 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 23 Mar 2021 14:00:15 +0000 Gerrit-HasComments: Yes
