Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17230 )
Change subject: IMPALA-10554: Block updates when row-filter/column-mask is enabled for the user ...................................................................... Patch Set 1: (1 comment) This generally lgtm. One question below. http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3104 PS1, Line 3104: authorize("insert into functional.alltypes partition(year, month) " + For an INSERT-SELECT, which error message would take precedence .. suppose the SELECT side has some authorization issue due to table masking, I assume that will error first before the 'block' on insertion is checked. -- To view, visit http://gerrit.cloudera.org:8080/17230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c899f2ec24b895867cbf2cf9ed23bc7b5a77326 Gerrit-Change-Number: 17230 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 06:53:31 +0000 Gerrit-HasComments: Yes
