Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17230 )
Change subject: IMPALA-10554: Block updates when row-filter/column-mask is enabled for the user ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@178 PS1, Line 178: || (authorizable.getType() != Type.TABLE && authorizable.getType() != Type.COLUMN)) { > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3104 PS1, Line 3104: authorize("insert into functional.alltypes partition(year, month) " + > For an INSERT-SELECT, which error message would take precedence .. suppose Good point! Yes, the 'block' on insertion happens when checking INSERT request on the table, which is later than checking the SELECT request. Note that requests are checked in the order as they are registered. In InsertStmt.analyze(), the query stmt is analyzed earlier than the target table, so the SELECT request is registered earlier than the INSERT request. Copied some test codes in testInsert() at line 832 here. -- To view, visit http://gerrit.cloudera.org:8080/17230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c899f2ec24b895867cbf2cf9ed23bc7b5a77326 Gerrit-Change-Number: 17230 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 08:57:16 +0000 Gerrit-HasComments: Yes
