Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17230 )
Change subject: IMPALA-10554: Block updates when row-filter/column-mask is enabled for the user ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17230/2/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/17230/2/fe/src/main/java/org/apache/impala/authorization/Privilege.java@93 PS2, Line 93: return this == ALTER || this == DROP || this == CREATE || this == INSERT Curious if INVALIDATE METADATA <table> command will/should be blocked with one of these. It's not listed in the Privilege enum but it is a more extreme version of the REFRESH command. That said, it seems unrelated to this patch since it was never being checked. http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/17230/1/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@3104 PS1, Line 3104: authorize("insert into functional.alltypes partition(year, month) " + > Good point! Yes, the 'block' on insertion happens when checking INSERT requ Thanks for adding the additional checks for the SELECT part. -- To view, visit http://gerrit.cloudera.org:8080/17230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c899f2ec24b895867cbf2cf9ed23bc7b5a77326 Gerrit-Change-Number: 17230 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 25 Mar 2021 15:54:40 +0000 Gerrit-HasComments: Yes
