Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17316 )

Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and 
Azure ABFS
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@588
PS1, Line 588:       return fs.exists(path);
If the qualified paths aren't the same and fs.exists(path) returns true, do we 
know they are on the same filesystem?

I'm wondering whether this should just return false.



--
To view, visit http://gerrit.cloudera.org:8080/17316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id807e8a200b83283a09d3a917185cabab930017d
Gerrit-Change-Number: 17316
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Apr 2021 16:52:57 +0000
Gerrit-HasComments: Yes

Reply via email to