Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17316 )
Change subject: IMPALA-10658: LOAD DATA INPATH silently fails between HDFS and Azure ABFS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/17316/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@588 PS1, Line 588: return fs.exists(path); > If the qualified paths aren't the same and fs.exists(path) returns true, do My idea was that 'path.equals(qp)' is the fast-path to check if the path is on the given filesystem. If that returns false because 'path' is not a qualified path, then the ultimate check is 'fs.exists(path)'. Currently we always pass a qualified path AFAICT, so we could only use the 'fast-path'. fs.exists(path) can be useful if this method was invoked with an unqualified path, e.g. '/tmp/data/file.csv'. The other option could be to throw an exception when 'path' is not qualified, but I'm not sure what is the best way to check that. -- To view, visit http://gerrit.cloudera.org:8080/17316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id807e8a200b83283a09d3a917185cabab930017d Gerrit-Change-Number: 17316 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 19 Apr 2021 13:00:23 +0000 Gerrit-HasComments: Yes
