Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17363 )
Change subject: IMPALA-10684: Report invalid parameter setting errors during HS2 OpenSession ...................................................................... Patch Set 1: (3 comments) Currently with hs2, any parameters supplied during OpenSession that fail the parsing check are logged and discarded. This is bad because the user may have made a simple mistake such as quoting the parameter value. The user would be able to determine that the parameter was not set using the set command or looking for the error in the log. Further confusing matters, the set statement does not run this check values either - parameters can be set to invalid values and are not reported until a query is executed. http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/common/status.h File be/src/common/status.h: http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/common/status.h@164 PS1, Line 164: // Same as Status(string) but can supress logging : Status(const std::string& error_msg, bool silent); > The "Expected" constructors are equivalent to the usual constructors with s Ack http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/common/status.h@183 PS1, Line 183: static Status Expected(const std::string& error_msg); > This is equivalent to silent=true. Ack http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/17363/1/be/src/service/impala-hs2-server.cc@364 PS1, Line 364: // Ignore failure (failures will be logged in SetQueryOption()). > Update this comment. Removed comment -- To view, visit http://gerrit.cloudera.org:8080/17363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a859bf5226feb903017a66f199ca5da916f217 Gerrit-Change-Number: 17363 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Tue, 11 May 2021 00:15:46 +0000 Gerrit-HasComments: Yes
