Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17363 )
Change subject: IMPALA-10684: Report invalid parameter setting errors during HS2 OpenSession ...................................................................... Patch Set 2: > (3 comments) > > Currently with hs2, any parameters supplied during OpenSession that > fail the parsing check are logged and discarded. This is bad > because the user may have made a simple mistake such as quoting the > parameter value. The user would be able to determine that the > parameter was not set using the set command or looking for the > error in the log. Further confusing matters, the set statement does > not run this check values either - parameters can be set to invalid > values and are not reported until a query is executed. I agree that silently dropping the invalid query options is a bad behavior. My concern is that this has been the behavior for 5+ years, and I have to assume that some users may rely on it. That reliance could be embedded in code, and it is not always easy to modify immediately. Returning an error here could cause existing use cases to be unable to open a session. One option is to use the SUCCESS_WITH_INFO status to return a message saying that some query options were ignored. Another option is we could have a startup parameter that enables the strict mode, though I don't know how we would stage enabling it. -- To view, visit http://gerrit.cloudera.org:8080/17363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a859bf5226feb903017a66f199ca5da916f217 Gerrit-Change-Number: 17363 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Tue, 11 May 2021 19:25:16 +0000 Gerrit-HasComments: No
