Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17363 )
Change subject: IMPALA-10684: Report invalid parameter setting errors during HS2 OpenSession ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17363/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/17363/2/be/src/service/impala-hs2-server.cc@364 PS2, Line 364: HS2_RETURN_IF_ERROR(return_val, SetQueryOption(v.first, v.second, : &state->set_query_options, &state->set_query_options_mask), : SQLSTATE_GENERAL_ERROR); : if (iequals(v.first, "idle_session_timeout")) { Another thing to consider is whether you want to detect all the bad query options and merge the status into a single error message. We do that in ParseQueryOptions here: https://github.com/apache/impala/blob/master/be/src/service/query-options.cc#L1098-L1121 -- To view, visit http://gerrit.cloudera.org:8080/17363 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a859bf5226feb903017a66f199ca5da916f217 Gerrit-Change-Number: 17363 Gerrit-PatchSet: 2 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Wed, 12 May 2021 23:36:59 +0000 Gerrit-HasComments: Yes
