Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17629 )
Change subject: IMPALA-10765: Don't update catalog when inserting empty results on unpartitioned tables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17629/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17629/1//COMMIT_MSG@10 PS1, Line 10: we don't need to update catalog since it takes : no effect I am unsure whether this will work with transactional tables: in that case the commit happens in UpdateCatalog(). While there is nothing to commit in that case, we still need to release the transaction somehow. -- To view, visit http://gerrit.cloudera.org:8080/17629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606 Gerrit-Change-Number: 17629 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 23 Jun 2021 16:42:18 +0000 Gerrit-HasComments: Yes
