Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17629 )
Change subject: IMPALA-10765: Don't update catalog when inserting empty results on unpartitioned tables ...................................................................... Patch Set 1: > I prefer to simply remove that Precondition. This came up earlier > with Iceberg tables, at that time I preferred to keep it (don't > remember why). Yes, I hit this precondition check while testing my other patch https://gerrit.cloudera.org/#/c/17308/. I think we can remove the preconditions check. -- To view, visit http://gerrit.cloudera.org:8080/17629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606 Gerrit-Change-Number: 17629 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 23 Jun 2021 18:05:29 +0000 Gerrit-HasComments: No
