Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17629 )
Change subject: IMPALA-10765: Allow firing insert events with empty files ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > > I prefer to simply remove that Precondition. This came up earlier > > with Iceberg tables, at that time I preferred to keep it (don't > > remember why). > > Yes, I hit this precondition check while testing my other patch > https://gerrit.cloudera.org/#/c/17308/. I think we can remove the > preconditions check. I guess the Precondition was added to avoid firing meaningless insert events. Added e2e tests and found that both solutions work. However, Hive does fire insert events for empty results. So I think it's ok to be consistent. I adjust the solution to just remove the checks. We can do optimizations in later patches. Thank Csaba and Vihang's quick review! http://gerrit.cloudera.org:8080/#/c/17629/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17629/1//COMMIT_MSG@10 PS1, Line 10: we don't need to update catalog since it takes : no effect > I am unsure whether this will work with transactional tables: in that case I think the coordinator will always abort the transaction at the end: https://github.com/apache/impala/blob/d99caa1f3a049fc5e20855f8e8bf846fd81f65c5/be/src/service/client-request-state.cc#L825 BTW, when no partitions are modified, we also skip calling updateCatalog(). -- To view, visit http://gerrit.cloudera.org:8080/17629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606 Gerrit-Change-Number: 17629 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 24 Jun 2021 03:17:40 +0000 Gerrit-HasComments: Yes
